Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: base/process/launch_posix.cc

Issue 2118583004: Remove unused function from base/process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/launch.h ('k') | base/process/process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/launch_posix.cc
diff --git a/base/process/launch_posix.cc b/base/process/launch_posix.cc
index 99582f59cfcfa760b1459b987e962c56d8a76c9d..5d3fbeee115740b796e581103a19710a1e8e506a 100644
--- a/base/process/launch_posix.cc
+++ b/base/process/launch_posix.cc
@@ -673,19 +673,6 @@ bool GetAppOutputAndError(const CommandLine& cl, std::string* output) {
return result == EXECUTE_SUCCESS && exit_code == EXIT_SUCCESS;
}
-// TODO(viettrungluu): Conceivably, we should have a timeout as well, so we
-// don't hang if what we're calling hangs.
-bool GetAppOutputRestricted(const CommandLine& cl,
- std::string* output, size_t max_output) {
- // Run |execve()| with the empty environment.
- char* const empty_environ = NULL;
- int exit_code;
- GetAppOutputInternalResult result = GetAppOutputInternal(
Lei Zhang 2016/07/01 06:41:48 All the callers to GetAppOutputInternal() now pass
benwells 2016/07/04 03:07:53 Good catch. Removed now.
- cl.argv(), &empty_environ, false, output, max_output, false, &exit_code);
- return result == GOT_MAX_OUTPUT || (result == EXECUTE_SUCCESS &&
- exit_code == EXIT_SUCCESS);
-}
-
bool GetAppOutputWithExitCode(const CommandLine& cl,
std::string* output,
int* exit_code) {
« no previous file with comments | « base/process/launch.h ('k') | base/process/process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698