Remove unused function from base/process

Remove unused function from base/process

GetAppOutputRestricted is not used anywhere.

BUG=88502
Committed: https://crrev.com/52162de75f5577f49f11c00ecc706a2b3b52e3c8
Cr-Commit-Position: refs/heads/master@{#403743}

[benwells, 2016-07-01 06:20:44]

benwells@chromium.org changed reviewers:
+ scottmg@chromium.org, thestig@chromium.org

[benwells, 2016-07-01 06:20:45]

thestig for base/
scottmg for build/

[Lei Zhang, 2016-07-01 06:41:49]

https://codereview.chromium.org/2118583004/diff/1/base/process/launch_posix.cc
File base/process/launch_posix.cc (left):

https://codereview.chromium.org/2118583004/diff/1/base/process/launch_posix.c...
base/process/launch_posix.cc:683: GetAppOutputInternalResult result =
GetAppOutputInternal(
All the callers to GetAppOutputInternal() now pass
std::numeric_limits<std::size_t>::max() as the max output now.

[scottmg, 2016-07-01 15:52:11]

build lgtm

[benwells, 2016-07-04 01:47:29]

Remove max_output

[benwells, 2016-07-04 03:07:53]

https://codereview.chromium.org/2118583004/diff/1/base/process/launch_posix.cc
File base/process/launch_posix.cc (left):

https://codereview.chromium.org/2118583004/diff/1/base/process/launch_posix.c...
base/process/launch_posix.cc:683: GetAppOutputInternalResult result =
GetAppOutputInternal(
On 2016/07/01 06:41:48, Lei Zhang wrote:
> All the callers to GetAppOutputInternal() now pass
> std::numeric_limits<std::size_t>::max() as the max output now.

Good catch. Removed now.

[Lei Zhang, 2016-07-04 20:33:04]

lgtm

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
File base/process/launch_posix.cc (right):

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:609: ssize_t bytes_read = 0;
This can be declared in the while loop now.

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:622: bool success = process.WaitForExit(exit_code);
No need for a success variable. Just return.

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:639: GetAppOutputInternal(argv, NULL, false,
output, true, &exit_code);
Might as well s/NULL/nullptr/ while we are here.

[benwells, 2016-07-05 02:33:37]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-07-05 02:33:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2118583004/#ps60001
(title: "Feedback")

[commit-bot: I haz the power, 2016-07-05 02:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-07-05 02:34:40]

The CQ bit was unchecked by benwells@chromium.org

[benwells, 2016-07-05 03:48:38]

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
File base/process/launch_posix.cc (right):

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:609: ssize_t bytes_read = 0;
On 2016/07/04 20:33:04, Lei Zhang wrote:
> This can be declared in the while loop now.

Done.

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:622: bool success = process.WaitForExit(exit_code);
On 2016/07/04 20:33:04, Lei Zhang wrote:
> No need for a success variable. Just return.

Done.

https://codereview.chromium.org/2118583004/diff/20001/base/process/launch_pos...
base/process/launch_posix.cc:639: GetAppOutputInternal(argv, NULL, false,
output, true, &exit_code);
On 2016/07/04 20:33:04, Lei Zhang wrote:
> Might as well s/NULL/nullptr/ while we are here.

Done.

[benwells, 2016-07-05 03:49:06]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-07-05 03:49:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2118583004/#ps80001
(title: "Fix NULL")

[commit-bot: I haz the power, 2016-07-05 03:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 05:41:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-05 05:42:49]

Description was changed from

==========
Remove unused function from base/process

GetAppOutputRestricted is not used anywhere.

BUG=88502
==========

to

==========
Remove unused function from base/process

GetAppOutputRestricted is not used anywhere.

BUG=88502

Committed: https://crrev.com/52162de75f5577f49f11c00ecc706a2b3b52e3c8
Cr-Commit-Position: refs/heads/master@{#403743}
==========

[commit-bot: I haz the power, 2016-07-05 05:42:50]

Patchset 5 (id:??) landed as
https://crrev.com/52162de75f5577f49f11c00ecc706a2b3b52e3c8
Cr-Commit-Position: refs/heads/master@{#403743}