third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html - Issue 2118583003: Display when PKP is bypassed in devtools

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

Issue 2118583003: Display when PKP is bypassed in devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/security_style_explanations.h ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

similarity index 53%

copy from third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

copy to third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

index 649896cb6c20e797728bf33fa5f4eff2c910d5d6..686b36393ada620fb4ce0cf584e18eb39105be49 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

@@ -7,7 +7,24 @@ function test()

{

var mixedContentStatus = { ranInsecureContent: false, displayedInsecureContent: false};

- InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, [], mixedContentStatus, true));

+ // Explanations from https://cbc.badssl.com/ as of 2016-06-13.

+ // We explicitly place the explanation with the security state "info"

+ // first to make sure it gets reordered.

+ var explanations = [

+ {

+ "description": "Public-key pinning was bypassed by a local root certificate.",

+ "securityState": "info",

+ "summary": "Public-Key Pinning Bypassed"

+ },

+ {

+ "certificateId": 1,

+ "description": "The connection to this site is using a valid, trusted server certificate.",

+ "securityState": "secure",

+ "summary": "Valid Certificate"

+ }

+ ];

+ InspectorTest.mainTarget.model(WebInspector.SecurityModel).dispatchEventToListeners(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, new WebInspector.PageSecurityState(SecurityAgent.SecurityState.Secure, explanations, mixedContentStatus, true));

var request = new WebInspector.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);

@@ -20,6 +37,6 @@ function test()

</script>

</head>

-<p>Tests addition of explanation when all page resources are transferred securely (no-mixed-content).</p>

+<p>Tests that info explanations are placed after regular explanations.</p>

</body>

</html>