third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js - Issue 2118583003: Display when PKP is bypassed in devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2118583003: Display when PKP is bypassed in devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/security/security-pkp-bypassed-expected.txt ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

index 56730c68612c7612d9871894e7e7390612325d22..9d0ecb7e0cf881a3d465acba6f37a8c623656cb4 100644

--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

@@ -74,12 +74,14 @@ WebInspector.SecurityModel.SecurityStateComparator = function(a, b)

* @param {!Array<!SecurityAgent.SecurityStateExplanation>} explanations

* @param {?SecurityAgent.MixedContentStatus} mixedContentStatus

* @param {boolean} schemeIsCryptographic

+ * @param {boolean} pkpBypassed

-WebInspector.PageSecurityState = function(securityState, explanations, mixedContentStatus, schemeIsCryptographic) {

+WebInspector.PageSecurityState = function(securityState, explanations, mixedContentStatus, schemeIsCryptographic, pkpBypassed) {

this.securityState = securityState;

this.explanations = explanations;

this.mixedContentStatus = mixedContentStatus;

this.schemeIsCryptographic = schemeIsCryptographic;

+ this.pkpBypassed = pkpBypassed;

}

/**

@@ -98,10 +100,11 @@ WebInspector.SecurityDispatcher.prototype = {

* @param {!Array<!SecurityAgent.SecurityStateExplanation>=} explanations

* @param {!SecurityAgent.MixedContentStatus=} mixedContentStatus

* @param {boolean=} schemeIsCryptographic

+ * @param {boolean=} pkpBypassed

- securityStateChanged: function(securityState, explanations, mixedContentStatus, schemeIsCryptographic)

+ securityStateChanged: function(securityState, explanations, mixedContentStatus, schemeIsCryptographic, pkpBypassed)

{

- var pageSecurityState = new WebInspector.PageSecurityState(securityState, explanations || [], mixedContentStatus || null, schemeIsCryptographic || false);

+ var pageSecurityState = new WebInspector.PageSecurityState(securityState, explanations || [], mixedContentStatus || null, schemeIsCryptographic || false, pkpBypassed || false);

this._model.dispatchEventToListeners(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, pageSecurityState);

}