Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2118583003: Display when PKP is bypassed in devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/Source/core/inspector/browser_protocol.json ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.SDKModel} 7 * @extends {WebInspector.SDKModel}
8 * @param {!WebInspector.Target} target 8 * @param {!WebInspector.Target} target
9 */ 9 */
10 WebInspector.SecurityModel = function(target) 10 WebInspector.SecurityModel = function(target)
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 return aScore - bScore; 68 return aScore - bScore;
69 } 69 }
70 70
71 /** 71 /**
72 * @constructor 72 * @constructor
73 * @param {!SecurityAgent.SecurityState} securityState 73 * @param {!SecurityAgent.SecurityState} securityState
74 * @param {!Array<!SecurityAgent.SecurityStateExplanation>} explanations 74 * @param {!Array<!SecurityAgent.SecurityStateExplanation>} explanations
75 * @param {?SecurityAgent.MixedContentStatus} mixedContentStatus 75 * @param {?SecurityAgent.MixedContentStatus} mixedContentStatus
76 * @param {boolean} schemeIsCryptographic 76 * @param {boolean} schemeIsCryptographic
77 * @param {boolean} pkpBypassed
77 */ 78 */
78 WebInspector.PageSecurityState = function(securityState, explanations, mixedCont entStatus, schemeIsCryptographic) { 79 WebInspector.PageSecurityState = function(securityState, explanations, mixedCont entStatus, schemeIsCryptographic, pkpBypassed) {
dgozman 2016/07/05 17:37:20 style: while you are here, please move { to the ne
dadrian 2016/07/06 18:35:46 Done.
79 this.securityState = securityState; 80 this.securityState = securityState;
80 this.explanations = explanations; 81 this.explanations = explanations;
81 this.mixedContentStatus = mixedContentStatus; 82 this.mixedContentStatus = mixedContentStatus;
82 this.schemeIsCryptographic = schemeIsCryptographic; 83 this.schemeIsCryptographic = schemeIsCryptographic;
84 this.pkpBypassed = pkpBypassed;
83 } 85 }
84 86
85 /** 87 /**
86 * @constructor 88 * @constructor
87 * @implements {SecurityAgent.Dispatcher} 89 * @implements {SecurityAgent.Dispatcher}
88 */ 90 */
89 WebInspector.SecurityDispatcher = function(model) 91 WebInspector.SecurityDispatcher = function(model)
90 { 92 {
91 this._model = model; 93 this._model = model;
92 } 94 }
93 95
94 WebInspector.SecurityDispatcher.prototype = { 96 WebInspector.SecurityDispatcher.prototype = {
95 /** 97 /**
96 * @override 98 * @override
97 * @param {!SecurityAgent.SecurityState} securityState 99 * @param {!SecurityAgent.SecurityState} securityState
98 * @param {!Array<!SecurityAgent.SecurityStateExplanation>=} explanations 100 * @param {!Array<!SecurityAgent.SecurityStateExplanation>=} explanations
99 * @param {!SecurityAgent.MixedContentStatus=} mixedContentStatus 101 * @param {!SecurityAgent.MixedContentStatus=} mixedContentStatus
100 * @param {boolean=} schemeIsCryptographic 102 * @param {boolean=} schemeIsCryptographic
103 * @param {boolean=} pkpBypassed
101 */ 104 */
102 securityStateChanged: function(securityState, explanations, mixedContentStat us, schemeIsCryptographic) 105 securityStateChanged: function(securityState, explanations, mixedContentStat us, schemeIsCryptographic, pkpBypassed)
103 { 106 {
104 var pageSecurityState = new WebInspector.PageSecurityState(securityState , explanations || [], mixedContentStatus || null, schemeIsCryptographic || false ); 107 var pageSecurityState = new WebInspector.PageSecurityState(securityState , explanations || [], mixedContentStatus || null, schemeIsCryptographic || false , pkpBypassed || false);
105 this._model.dispatchEventToListeners(WebInspector.SecurityModel.EventTyp es.SecurityStateChanged, pageSecurityState); 108 this._model.dispatchEventToListeners(WebInspector.SecurityModel.EventTyp es.SecurityStateChanged, pageSecurityState);
106 } 109 }
107 } 110 }
OLDNEW
« third_party/WebKit/Source/core/inspector/browser_protocol.json ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698