Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2118523002: Fix ThreadTaskRunnerHandle check in BrowserContext. (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ThreadTaskRunnerHandle check in BrowserContext. We want IsSet(), not Get(). Get() DCHECKs if null. BUG= TBR=ben@chromium.org Committed: https://crrev.com/dced2d04ce3484e6830e1f971dfbf571b5e2771c Cr-Commit-Position: refs/heads/master@{#403262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118523002/1
4 years, 5 months ago (2016-06-30 17:52:55 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/29757)
4 years, 5 months ago (2016-06-30 17:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118523002/1
4 years, 5 months ago (2016-06-30 19:06:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 20:08:39 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:09:00 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:11:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dced2d04ce3484e6830e1f971dfbf571b5e2771c
Cr-Commit-Position: refs/heads/master@{#403262}

Powered by Google App Engine
This is Rietveld 408576698