Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py

Issue 2118513002: Make rebaseline-from-try-jobs actually download baselines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py
index 68bd5817cacb7f934976ad1c93ab577d094030e2..30820fcab93c84d1a34c099522ba24ce71ae1927 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py
@@ -10,6 +10,7 @@ from webkitpy.layout_tests.builder_list import BuilderList
from webkitpy.tool.commands.rebaseline_from_try_jobs import RebaselineFromTryJobs
from webkitpy.tool.commands.rebaseline_unittest import BaseTestCase
from webkitpy.tool.mock_tool import MockOptions
+from webkitpy.layout_tests.builder_list import BuilderList
class RebaselineFromTryJobsTest(BaseTestCase):
@@ -27,6 +28,10 @@ class RebaselineFromTryJobsTest(BaseTestCase):
'builder': 'MOCK Try Win',
'buildnumber': 5000,
},
+ {
+ 'builder': 'MOCK Mac Try',
+ 'buildnumber': 4000,
+ },
],
}),
})
@@ -47,17 +52,19 @@ class RebaselineFromTryJobsTest(BaseTestCase):
oc = OutputCapture()
try:
oc.capture_output()
- self.command.execute(MockOptions(issue=11112222), [], self.tool)
+ options = MockOptions(issue=11112222, dry_run=False, optimize=True, verbose=False)
+ self.command.execute(options, [], self.tool)
finally:
_, _, logs = oc.restore_output()
self.assertEqual(
logs,
- ('Getting results for Rietveld issue 11112222.\n'
- ' Builder: MOCK Try Win\n'
- ' Build: 5000\n'
- 'fast/dom/prototype-inheritance.html (actual: TEXT, expected: PASS)\n'
- 'fast/dom/prototype-taco.html (actual: PASS TEXT, expected: PASS)\n'
- 'svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html (actual: IMAGE, expected: PASS)\n'))
+ ('Tests to rebaseline:\n'
+ ' svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: MOCK Try Win\n'
+ ' fast/dom/prototype-inheritance.html: MOCK Try Win\n'
+ ' fast/dom/prototype-taco.html: MOCK Try Win\n'
+ 'Rebaselining fast/dom/prototype-inheritance.html\n'
+ 'Rebaselining fast/dom/prototype-taco.html\n'
+ 'Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html\n'))
def test_execute_with_no_issue_number(self):
oc = OutputCapture()
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698