Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4847)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2118503005: [MD settings] disable clear browsing data while it is running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added status message for removing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 9e12be054b20b9017f3bf3c858329eb5e34f4cd3..bec9167bb8a56433fe7aa3af91c52940f5bf815e 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -175,10 +175,15 @@ class BrowsingDataRemover : public KeyedService
base::Time end;
};
- // Observer is notified when the removal is done. Done means keywords have
- // been deleted, cache cleared and all other tasks scheduled.
+ // Observer is notified when the removal is active and when it's done.
class Observer {
public:
+ // Whether removal is active. Note that not having an active removal is not
+ // same as completing a removal. That is why the removing status is separate
+ // from the done message.
+ virtual void OnBrowsingDataRemoving(bool is_removing) {}
Dan Beam 2016/07/07 18:06:49 \n
dschuyler 2016/07/20 19:01:14 Done.
+ // Done means keywords have been deleted, cache cleared and all other
+ // removal tasks are scheduled.
virtual void OnBrowsingDataRemoverDone() = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698