Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4153)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

Issue 2118503005: [MD settings] disable clear browsing data while it is running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
index d90a81b312c83681dcf5e1be583a28aeceadd521..1452b9f5bf8880d3dc7802f565344533cde6be64 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
@@ -17,7 +17,10 @@ cr.define('settings', function() {
*/
clearBrowsingData: function() {},
- /** Initializes the dialog. */
+ /**
+ * Kick off counter updates and return initial state.
+ * @return {!Promise} Whether clear browsing data is in progress.
Dan Beam 2016/07/06 22:13:06 !Promise<boolean>
dschuyler 2016/07/07 01:25:33 I ended up changing this to not send a boolean.
+ */
initialize: function() {},
};
@@ -36,7 +39,7 @@ cr.define('settings', function() {
/** @override */
initialize: function() {
- chrome.send('initializeClearBrowsingData');
+ return cr.sendWithPromise('initializeClearBrowsingData');
},
};

Powered by Google App Engine
This is Rietveld 408576698