Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2118503004: Media Router: Remove unnecessary and incorrect static_cast in test. (Closed)

Created:
4 years, 5 months ago by pcc1
Modified:
4 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Router: Remove unnecessary and incorrect static_cast in test. The SigninManager object here is in fact of type SigninManager, not FakeSigninManagerForTesting. The bad cast here caused test failures in CFI mode [1]. Because the test is not using any members of FakeSigninManagerForTesting, we can simply remove the cast. [1] https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5924/steps/unit_tests/logs/MediaRouterContextualMenuUnitTest.Basic BUG=464797 R=pkasting@chromium.org Committed: https://crrev.com/b25eb565ec1125425d4777e1a7580b0857c64c53 Cr-Commit-Position: refs/heads/master@{#403483}

Patch Set 1 #

Patch Set 2 : Add missing #include #

Patch Set 3 : SigninManagerBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
pcc1
4 years, 5 months ago (2016-06-30 21:19:56 UTC) #1
Peter Kasting
LGTM
4 years, 5 months ago (2016-07-01 07:45:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118503004/1
4 years, 5 months ago (2016-07-01 16:35:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/225235)
4 years, 5 months ago (2016-07-01 16:50:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118503004/20001
4 years, 5 months ago (2016-07-01 17:10:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/225253)
4 years, 5 months ago (2016-07-01 17:24:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118503004/40001
4 years, 5 months ago (2016-07-01 17:30:48 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-01 18:24:59 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 18:25:06 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 18:27:10 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b25eb565ec1125425d4777e1a7580b0857c64c53
Cr-Commit-Position: refs/heads/master@{#403483}

Powered by Google App Engine
This is Rietveld 408576698