Expose a constructor for WebCryptoAlgorithm.

public/platform/WebCryptoAlgorithm.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
 class WebCryptoAlgorithmPrivate;
 
 // The WebCryptoAlgorithm represents a normalized algorithm and its parameters.
 //   * Immutable
 //   * Threadsafe
 //   * Copiable (cheaply)
 class WebCryptoAlgorithm {
 public:
 #if WEBKIT_IMPLEMENTATION
     WebCryptoAlgorithm() { }
-    WebCryptoAlgorithm(WebCryptoAlgorithmId, const char*, PassOwnPtr<WebCryptoAlgorithmParams>);
+    WebCryptoAlgorithm(WebCryptoAlgorithmId, const char* name, PassOwnPtr<WebCryptoAlgorithmParams>);
+#else
+    WebCryptoAlgorithm(WebCryptoAlgorithmId id, const char* name, WebCryptoAlgorithmParams* params)
+    {
+        assign(id, name, params);
+    }

[abarth-chromium, 2013/07/31 00:46:51]

It's not at all obvious that this constructor takes ownership of the
WebCryptoAlgorithmParams object.  Is there some way we could make that more
obvious?  Maybe instead of a constructor it should be a create function who's
name says something about adopting?

[eroman, 2013/07/31 01:49:26]

Good idea. Done

 #endif
 
     ~WebCryptoAlgorithm() { reset(); }
 
     WebCryptoAlgorithm(const WebCryptoAlgorithm& other) { assign(other); }
     WebCryptoAlgorithm& operator=(const WebCryptoAlgorithm& other)
     {
         assign(other);
         return *this;
     }
 
     WEBKIT_EXPORT WebCryptoAlgorithmId id() const;
     WEBKIT_EXPORT const char* name() const;
 
     WEBKIT_EXPORT WebCryptoAlgorithmParamsType paramsType() const;
 
     // Retrieves the type-specific parameters. The algorithm contains at most 1
     // type of parameters. Retrieving an invalid parameter will return 0.
     WEBKIT_EXPORT WebCryptoAesCbcParams* aesCbcParams() const;
     WEBKIT_EXPORT WebCryptoAesKeyGenParams* aesKeyGenParams() const;
     WEBKIT_EXPORT WebCryptoHmacParams* hmacParams() const;
 
 private:
     WEBKIT_EXPORT void assign(const WebCryptoAlgorithm& other);
+    WEBKIT_EXPORT void assign(WebCryptoAlgorithmId, const char* name, WebCryptoAlgorithmParams*);
     WEBKIT_EXPORT void reset();
 
     WebPrivatePtr<WebCryptoAlgorithmPrivate> m_private;
 };
 
 } // namespace WebKit
 
 #endif