extensions/browser/extension_function.h - Issue 2118473002: 😴 Skip some KeepAlive registrations on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.h

Issue 2118473002: 😴 Skip some KeepAlive registrations on shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_function.h

diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h

index 59715691619f4e98f884486fcbdc2b88a77dd140..d6a0ad401abb836edcde59ec5b4bdb9fb4587a59 100644

--- a/extensions/browser/extension_function.h

+++ b/extensions/browser/extension_function.h

@@ -493,6 +493,8 @@ class UIThreadExtensionFunction : public ExtensionFunction {

UIThreadExtensionFunction* AsUIThreadExtensionFunction() override;

+ bool PreRunValidation(std::string* error) override;

void set_test_delegate(DelegateForTests* delegate) {

delegate_ = delegate;

}