chrome/browser/lifetime/scoped_keep_alive.h - Issue 2118473002: 😴 Skip some KeepAlive registrations on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/scoped_keep_alive.h

Issue 2118473002: 😴 Skip some KeepAlive registrations on shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/lifetime/scoped_keep_alive.h

diff --git a/chrome/browser/lifetime/scoped_keep_alive.h b/chrome/browser/lifetime/scoped_keep_alive.h

index 5dbc4b9196b2ca11e51ef6e7f506321f8771da5b..48c32680a9ae849cf00b206f9deb3bfa0feb2bea 100644

--- a/chrome/browser/lifetime/scoped_keep_alive.h

+++ b/chrome/browser/lifetime/scoped_keep_alive.h

@@ -12,6 +12,8 @@ enum class KeepAliveRestartOption;

// Registers with KeepAliveRegistry on creation and unregisters them

// on destruction. Use these objects with a scoped_ptr for easy management.

+// Note: The registration will hit a CHECK if it happens while we are

+// shutting down. Caller code should make sure that this can't happen.

class ScopedKeepAlive {

public:

ScopedKeepAlive(KeepAliveOrigin origin, KeepAliveRestartOption restart);