😴 Skip some KeepAlive registrations on shutdown.

chrome/browser/extensions/chrome_extension_function_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+
+#include "chrome/browser/extensions/extension_service_test_base.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "extensions/browser/extension_function.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+int g_callback_runs = 0;

[Devlin, 2016/07/15 17:59:39]

global variables are pretty fragile in unittests that can run in parallel.  I
think this would be simpler by doing something like:

void SuccessCallback(bool* did_respond,
                     ...) {
  EXPECT_EQ(...);
  *did_respond = true;
}

and then use
set_response_callback(base::Bind((should_succeed ? &SuccessCallback :
&FailureCallback), &did_respond_));

where did_respond_ can be a bool in ValidationFunction

and then you can EXPECT_TRUE(function->did_respond()) in the test body.

That way, we keep all the state in objects that we know will be properly
initialized/cleaned up.

[dgn, 2016/07/18 14:44:04]

Thanks! I didn't think about using Bind like that. Really nice.

+
+void SuccessCallback(ExtensionFunction::ResponseType type,
+                     const base::ListValue& results,
+                     const std::string& error,
+                     functions::HistogramValue histogram_value) {
+  EXPECT_EQ(ExtensionFunction::ResponseType::SUCCEEDED, type);
+  ++g_callback_runs;
+}
+
+void FailCallback(ExtensionFunction::ResponseType type,
+                  const base::ListValue& results,
+                  const std::string& error,
+                  functions::HistogramValue histogram_value) {
+  EXPECT_EQ(ExtensionFunction::ResponseType::FAILED, type);
+  ++g_callback_runs;
+}
+
+}  // namespace
+
+class ChromeExtensionFunctionUnitTest : public ExtensionServiceTestBase {
+
+ public:
+  void TearDown() override {
+    g_callback_runs = 0;
+    ExtensionServiceTestBase::TearDown();
+  }
+
+};
+
+class ValidationFunction : public UIThreadExtensionFunction {
+ public:
+  explicit ValidationFunction(bool should_succeed)
+      : should_succeed_(should_succeed) {
+    set_response_callback(should_succeed ? base::Bind(&SuccessCallback)
+                                         : base::Bind(&FailCallback));
+  }
+
+  ResponseAction Run() override {
+    EXPECT_TRUE(should_succeed_);
+    return RespondNow(NoArguments());
+  }
+
+ private:
+  ~ValidationFunction() override {}
+  bool should_succeed_;
+};
+
+
+
+TEST_F(ChromeExtensionFunctionUnitTest, SimpleFunctionTest) {
+  scoped_refptr<ExtensionFunction> function(new ValidationFunction(true));
+  function->RunWithValidation()->Execute();
+  EXPECT_EQ(1, g_callback_runs);
+}
+
+TEST_F(ChromeExtensionFunctionUnitTest, BrowserShutdownValidationFunctionTest) {
+  TestingBrowserProcess::GetGlobal()->SetShuttingDown(true);
+  scoped_refptr<ExtensionFunction> function(new ValidationFunction(false));
+  function->RunWithValidation()->Execute();
+  TestingBrowserProcess::GetGlobal()->SetShuttingDown(false);
+  EXPECT_EQ(1, g_callback_runs);
+}
+
+}  // namespace extensions