Convert video-controls-visibility* tests to testharness.js

Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/94cbc4321c3a084b7417325dee296dc4843808b5
Cr-Commit-Position: refs/heads/master@{#403178}

[Srirama, 2016-06-30 13:16:02]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-30 13:17:44]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-30 13:17:44]

PTAL

[fs, 2016-06-30 13:43:58]

lgtm

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html
(right):

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html:24:
// The controls should be shown after exiting the fullscreen.
Nit: drop "the" before "fullscreen".

[foolip, 2016-06-30 13:53:15]

lgtm

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html
(right):

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html:31:
var panel = mediaControlsButton(video, "panel");
Maybe hoist this to the top since it's used above? Doesn't matter, but is easier
to follow.

[Srirama, 2016-06-30 13:56:58]

Patchset #2 (id:20001) has been deleted

[Srirama, 2016-06-30 13:58:04]

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html
(right):

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html:24:
// The controls should be shown after exiting the fullscreen.
On 2016/06/30 13:43:58, fs wrote:
> Nit: drop "the" before "fullscreen".

Done.

https://codereview.chromium.org/2118453002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html:31:
var panel = mediaControlsButton(video, "panel");
On 2016/06/30 13:53:15, Philip Jägenstedt wrote:
> Maybe hoist this to the top since it's used above? Doesn't matter, but is
easier
> to follow.

Done.

[Srirama, 2016-06-30 13:58:11]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-30 13:58:12]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2118453002/#ps40001
(title: "address nits")

[commit-bot: I haz the power, 2016-06-30 13:58:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 15:12:12]

Description was changed from

==========
Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-30 15:12:15]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-30 15:13:32]

Description was changed from

==========
Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-controls-visibility* tests to testharness.js

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/94cbc4321c3a084b7417325dee296dc4843808b5
Cr-Commit-Position: refs/heads/master@{#403178}
==========

[commit-bot: I haz the power, 2016-06-30 15:13:33]

Patchset 2 (id:??) landed as
https://crrev.com/94cbc4321c3a084b7417325dee296dc4843808b5
Cr-Commit-Position: refs/heads/master@{#403178}