Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 211843004: Tunnel PWGRasterConfig capability to the ticket and to the utility process (Closed)

Created:
6 years, 9 months ago by Noam Samuel
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Tunnel PWGRasterConfig capability to the ticket and to the utility process Parse the PWGRasterConfig capability for local printing, copy it to the ticket, and tunnel a data structure based on it to the utility process. BUG=354605 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259938

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -22 lines) Patch
M chrome/browser/local_discovery/privet_http_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 6 chunks +67 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 6 chunks +88 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.cc View 1 6 chunks +16 lines, -9 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 3 chunks +18 lines, -5 lines 0 comments Download
A printing/pwg_raster_settings.h View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Noam Samuel
vitalybuka@ for general review thestig@ for chrome_content_utility_client jorgelo@ for IPC security review
6 years, 9 months ago (2014-03-25 23:02:03 UTC) #1
Lei Zhang
chrome_content_utility_client.* lgtm
6 years, 9 months ago (2014-03-26 00:21:47 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode619 chrome/browser/local_discovery/privet_http_impl.cc:619: cloud_devices::printer::PwgRasterConfigCapability raster_capability; using namespace cloud_devices::printer; https://codereview.chromium.org/211843004/diff/1/chrome/common/chrome_utility_messages.h File chrome/common/chrome_utility_messages.h ...
6 years, 9 months ago (2014-03-26 00:31:12 UTC) #3
Noam Samuel
https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode619 chrome/browser/local_discovery/privet_http_impl.cc:619: cloud_devices::printer::PwgRasterConfigCapability raster_capability; On 2014/03/26 00:31:12, Vitaly Buka wrote: > ...
6 years, 9 months ago (2014-03-26 18:54:28 UTC) #4
Jorge Lucangeli Obes
On 2014/03/26 18:54:28, Noam Samuel wrote: > https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc > File chrome/browser/local_discovery/privet_http_impl.cc (right): > > https://codereview.chromium.org/211843004/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode619 ...
6 years, 9 months ago (2014-03-26 21:05:50 UTC) #5
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-26 21:15:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/211843004/70001
6 years, 9 months ago (2014-03-26 21:16:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 04:57:44 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289083
6 years, 9 months ago (2014-03-27 04:57:44 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-27 17:48:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/211843004/70001
6 years, 9 months ago (2014-03-27 17:48:33 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 18:29:08 UTC) #12
Message was sent while issue was closed.
Change committed as 259938

Powered by Google App Engine
This is Rietveld 408576698