X87: [builtins] Add receiver to builtin exit frames.

X87: [builtins] Add receiver to builtin exit frames.

  port f59a23356b437e369d75445177fea838ee5bccc7 (r37500)

  original commit message:
  Stack trace generation requires access to the receiver; and while the
  receiver is already on the stack, we cannot determine its position
  during stack trace generation (it's stored in argv[0], and argc is only
  stored in a callee-saved register).

  This patch grants access to the receiver by pushing argc onto builtin
  exit frames as an extra argument. Compared to simply pushing the
  receiver, this requires an additional dereference during stack trace
  generation, but one fewer during builtin calls.

BUG=

Committed: https://crrev.com/e043dcb5d694ad65b7b273ab08d22ca10d972156
Cr-Commit-Position: refs/heads/master@{#37511}

[zhengxing.li, 2016-07-05 02:38:18]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, jgruber@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-07-05 02:38:19]

PTAL, thanks!

[Weiliang, 2016-07-05 02:48:20]

lgtm

[zhengxing.li, 2016-07-05 05:14:09]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-07-05 05:14:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 05:37:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-05 05:37:44]

Description was changed from

==========
X87: [builtins] Add receiver to builtin exit frames.

  port f59a23356b437e369d75445177fea838ee5bccc7 (r37500)

  original commit message:
  Stack trace generation requires access to the receiver; and while the
  receiver is already on the stack, we cannot determine its position
  during stack trace generation (it's stored in argv[0], and argc is only
  stored in a callee-saved register).

  This patch grants access to the receiver by pushing argc onto builtin
  exit frames as an extra argument. Compared to simply pushing the
  receiver, this requires an additional dereference during stack trace
  generation, but one fewer during builtin calls.

BUG=
==========

to

==========
X87: [builtins] Add receiver to builtin exit frames.

  port f59a23356b437e369d75445177fea838ee5bccc7 (r37500)

  original commit message:
  Stack trace generation requires access to the receiver; and while the
  receiver is already on the stack, we cannot determine its position
  during stack trace generation (it's stored in argv[0], and argc is only
  stored in a callee-saved register).

  This patch grants access to the receiver by pushing argc onto builtin
  exit frames as an extra argument. Compared to simply pushing the
  receiver, this requires an additional dereference during stack trace
  generation, but one fewer during builtin calls.

BUG=

Committed: https://crrev.com/e043dcb5d694ad65b7b273ab08d22ca10d972156
Cr-Commit-Position: refs/heads/master@{#37511}
==========

[commit-bot: I haz the power, 2016-07-05 05:37:45]

Patchset 1 (id:??) landed as
https://crrev.com/e043dcb5d694ad65b7b273ab08d22ca10d972156
Cr-Commit-Position: refs/heads/master@{#37511}