Reorganize Layout Tree Construction code to be its own function

third_party/WebKit/Source/core/dom/Element.h

Index: third_party/WebKit/Source/core/dom/Element.h
diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h
index 0cc727779c3f23970d0b5af2ba0efe72fe275fbf..f6240585e573cb6a44209efcabdbeff35a01b0ce 100644
--- a/third_party/WebKit/Source/core/dom/Element.h
+++ b/third_party/WebKit/Source/core/dom/Element.h
@@ -650,6 +650,7 @@ private:
     void setInlineStyleFromString(const AtomicString&);
 
     StyleRecalcChange recalcOwnStyle(StyleRecalcChange);
+    StyleRecalcChange buildOwnLayout(ComputedStyle*);

[sashab, 2016/07/05 23:28:55]

TODO(nainar): Make this const ComputedStyle*.

[Bugs Nash, 2016/07/06 00:24:26]

Would PassRefPtr be better than raw ptr?

[nainar, 2016/07/06 00:52:09]

Done.

[sashab, 2016/07/06 02:17:25]

From https://webkit.org/blog/5381/refptr-basics/:
"Later, in 2013, we noticed that our use of pointers in general, and smart
pointers in particular, was causing a proliferation of null checks and
uncertainty about what can be null. We started using references rather than
pointers wherever possible in WebKit code."

So, actually, it should be a reference! :) Make it a reference, remove the
DCHECK and then use &newStyle to assign it to reattachContext, since that can
actually be null. Technically this isn't great but ReattachContext can actually
store a null ComputedStyle. Let's investigate making it const another day 8^)

 
     inline void checkForEmptyStyleChange();