Fix "conversion of size_t to unsigned int" warning

net/dns/record_rdata_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/record_rdata.h"
 
 #include <memory>
 
 #include "net/dns/dns_response.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 178 matching lines @@
   EXPECT_FALSE(record_obj->GetBit(0));
   EXPECT_TRUE(record_obj->GetBit(1));
   for (int i = 2; i < 15; i++) {
     EXPECT_FALSE(record_obj->GetBit(i));
   }
   EXPECT_TRUE(record_obj->GetBit(15));
 
   ASSERT_TRUE(record_obj->IsEqual(record_obj.get()));
 }
 
+TEST(RecordRdataTest, CreateNsecRecordWithEmptyBitmapReturnsNull) {
+  std::unique_ptr<NsecRecordRdata> record_obj;

[Ryan Sleevi, 2016/07/06 17:48:25]

STYLE: Keep this scoped closer to where it's used - per
https://google.github.io/styleguide/cppguide.html#Local_Variables

That is, line 211

std::unique_ptr<NsecRecordRdata> record_obj = NSecRecordRdata...
ASSERT_FALSE(record_obj);

+
+  // These are just the rdata portions of the DNS records, rather than complete
+  // records, but it works well enough for this test.
+  // This record has a bitmap that is 0 bytes long.
+  const uint8_t record[] = {0x03, 'w', 'w',  'w', 0x06, 'g', 'o',  'o',  'g',
+                            'l',  'e', 0x03, 'c', 'o',  'm', 0x00, 0x00, 0x00};
+
+  DnsRecordParser parser(record, sizeof(record), 0);
+  base::StringPiece record_strpiece = MakeStringPiece(record, sizeof(record));
+
+  record_obj = NsecRecordRdata::Create(record_strpiece, parser);
+  ASSERT_EQ(nullptr, record_obj);

[Ryan Sleevi, 2016/07/06 17:48:25]

ASSERT_FALSE(record_obj)

+}
+
+TEST(RecordRdataTest, CreateNsecRecordWithOversizedBitmapReturnsNull) {
+  std::unique_ptr<NsecRecordRdata> record_obj;
+
+  // These are just the rdata portions of the DNS records, rather than complete
+  // records, but it works well enough for this test.
+  // This record has a bitmap that is 33 bytes long. The maximum size allowed by
+  // RFC 3845, Section 2.1.2, is 32 bytes.
+  const uint8_t record[] = {
+      0x03, 'w',  'w',  'w',  0x06, 'g',  'o',  'o',  'g',  'l',  'e',
+      0x03, 'c',  'o',  'm',  0x00, 0x00, 0x21, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
+
+  DnsRecordParser parser(record, sizeof(record), 0);
+  base::StringPiece record_strpiece = MakeStringPiece(record, sizeof(record));
+
+  record_obj = NsecRecordRdata::Create(record_strpiece, parser);
+  ASSERT_EQ(nullptr, record_obj);

[Ryan Sleevi, 2016/07/06 17:48:25]

ASSERT_FALSE(record_obj)

+}
 
 }  // namespace net