Fix "conversion of size_t to unsigned int" warning

net/dns/record_rdata.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DNS_RECORD_RDATA_H_
 #define NET_DNS_RECORD_RDATA_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 180 matching lines @@
  public:
   static const uint16_t kType = dns_protocol::kTypeNSEC;
 
   ~NsecRecordRdata() override;
   static std::unique_ptr<NsecRecordRdata> Create(const base::StringPiece& data,
                                                  const DnsRecordParser& parser);
   bool IsEqual(const RecordRdata* other) const override;
   uint16_t Type() const override;
 
   // Length of the bitmap in bits.
-  unsigned bitmap_length() const { return bitmap_.size() * 8; }
+  // This will be between 8-256, as the bitmap is required to be between 1-32
+  // bytes long (this is verified by Create()).

[Ryan Sleevi, 2016/07/06 16:29:03]

This is the sort of comment that makes me uneasy in the header (the
parenthetical), because that talks about implementation.

// This will be between 8 and 256 bits long, per RFC [blah] Section [blah]

[Rob Percival, 2016/07/06 17:14:44]

I had the same feeling when I wrote it. I wasn't convinced just referring to the
RFC would be sufficient though, since what the RFC allows and what comes over
the network can be very different. I wanted to say something closer to what the
DCHECK was intended to express - that it is an internal guarantee.

+  uint16_t bitmap_length() const {
+    return static_cast<uint16_t>(bitmap_.size() * 8);
+  }
 
   // Returns bit i-th bit in the bitmap, where bits withing a byte are organized
   // most to least significant. If it is set, a record with rrtype i exists for
   // the domain name of this nsec record.
   bool GetBit(unsigned i) const;
 
  private:
   NsecRecordRdata();
 
   std::vector<uint8_t> bitmap_;
 
   DISALLOW_COPY_AND_ASSIGN(NsecRecordRdata);
 };
 
 
 }  // namespace net
 
 #endif  // NET_DNS_RECORD_RDATA_H_