Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2118383004:
Enable TestWSSInvalidCertAndClose on Windows (Closed)
|
Created:
4 years, 5 months ago by Takashi Toyoshima Modified:
4 years, 5 months ago Reviewers:
felt CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable TestWSSInvalidCertAndClose on Windows
The test was disabled on Windows because it was flaky on XP bots.
Now that we do not support XP any more, let's enable it again
to see what will happen on other Windows bots.
BUG=165258
TBR=felt@chromium.org
Committed: https://crrev.com/1cfcbf9f6646f0f9a005c8b325822f4b47470460
Cr-Commit-Position: refs/heads/master@{#404077}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
toyoshim@chromium.org changed reviewers: + palmer@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 ========== to ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 ==========
toyoshim@chromium.org changed reviewers: - palmer@chromium.org
toyoshim@chromium.org changed reviewers: + felt@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
felt, can you take a look?
Description was changed from ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 ========== to ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 TBR=felt@chromium.org ==========
This sort of revert CL could be submitted with TBR. If someone notice this CL makes some tests flaky, please revert this again.
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 TBR=felt@chromium.org ========== to ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 TBR=felt@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 TBR=felt@chromium.org ========== to ========== Enable TestWSSInvalidCertAndClose on Windows The test was disabled on Windows because it was flaky on XP bots. Now that we do not support XP any more, let's enable it again to see what will happen on other Windows bots. BUG=165258 TBR=felt@chromium.org Committed: https://crrev.com/1cfcbf9f6646f0f9a005c8b325822f4b47470460 Cr-Commit-Position: refs/heads/master@{#404077} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1cfcbf9f6646f0f9a005c8b325822f4b47470460 Cr-Commit-Position: refs/heads/master@{#404077}
Message was sent while issue was closed.
lgtm (and i agree, TBR here is fine) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
