Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: services/ui/public/cpp/window.h

Issue 2118383002: mus: Disregard windows that explicitly set can_accept_events to be false when sending events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Early return Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/window.h
diff --git a/services/ui/public/cpp/window.h b/services/ui/public/cpp/window.h
index c902e58eee4acff2e19626e1374ba64e0109ade0..db3b1ff97f763e6bc85c85e43c947bc8b4768e62 100644
--- a/services/ui/public/cpp/window.h
+++ b/services/ui/public/cpp/window.h
@@ -209,6 +209,9 @@ class Window {
bool HasFocus() const;
void SetCanFocus(bool can_focus);
+ // Sets whether this window accepts events.
+ void SetCanAcceptEvents(bool can_accept_events);
+
// Embedding. See window_tree.mojom for details.
void Embed(ui::mojom::WindowTreeClientPtr client, uint32_t flags = 0);
@@ -339,6 +342,12 @@ class Window {
float opacity_;
int64_t display_id_;
+ // Whether this window can accept events.
+ // Only call SetCanAcceptEvents if the new setting is different from
msw 2016/07/12 22:07:23 nit: move this sentence up to |SetCanAcceptEvents|
riajiang 2016/07/13 00:01:45 Done.
+ // the current one. Initialize it to be true since server window will
msw 2016/07/12 22:07:23 nit: "Initialized to true to match ServerWindow".
riajiang 2016/07/13 00:01:45 Done.
+ // also initialize can_accept_events_ to be true.
msw 2016/07/12 22:07:23 nit: |can_accept_events_| (if you keep this)
+ bool can_accept_events_ = true;
+
mojom::Cursor cursor_id_;
SharedProperties properties_;

Powered by Google App Engine
This is Rietveld 408576698