Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2118373002: Added more counters for PointerEvents UMA metric. (Closed)

Created:
4 years, 5 months ago by mustaq
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, nzolghadr+blinkwatch_chromium.org, dtapuska+blinkwatch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added more counters for PointerEvents UMA metric. Added counter for setPointerCapture, and for non-JS event dispatch. BUG=624546 TBR=isherman@chromium.org Committed: https://crrev.com/5d78eb3bc27aeb8540b6d21175ee382686b3e357 Cr-Commit-Position: refs/heads/master@{#403730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mustaq
ptal
4 years, 5 months ago (2016-07-04 21:12:42 UTC) #2
dtapuska
On 2016/07/04 21:12:42, mustaq wrote: > ptal lgtm
4 years, 5 months ago (2016-07-04 21:18:12 UTC) #3
Rick Byers
LGTM Note that you can TBR a metrics OWNER when all you're doing is expanding ...
4 years, 5 months ago (2016-07-04 21:22:41 UTC) #4
mustaq
ptal, need approval for histograms.xml.
4 years, 5 months ago (2016-07-04 21:23:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118373002/1
4 years, 5 months ago (2016-07-04 21:26:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 00:56:16 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5d78eb3bc27aeb8540b6d21175ee382686b3e357 Cr-Commit-Position: refs/heads/master@{#403730}
4 years, 5 months ago (2016-07-05 00:57:41 UTC) #13
Ilya Sherman
4 years, 5 months ago (2016-07-05 21:37:37 UTC) #14
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698