Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2118313002: Do not create more than one ElementVisibilityObserver. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not create more than one ElementVisibilityObserver. In some rare cases, we might have an ElementVisibilityObserver pending and be back in a situation where we want to create one. In this case, instead of creating another one, we can just skip the step. BUG=624927 TEST=cluster-fuzz R=zqzhang@chromium.org Committed: https://crrev.com/53768efa825a826a9e3273b608415cea1cfd6361 Cr-Commit-Position: refs/heads/master@{#403684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118313002/1
4 years, 5 months ago (2016-07-04 14:08:05 UTC) #2
Zhiqiang Zhang (Slow)
lgtm. Though I wonder how can the crash be triggered. Is there some bugs in ...
4 years, 5 months ago (2016-07-04 14:55:02 UTC) #3
mlamouri (slow - plz ping)
On 2016/07/04 at 14:55:02, zqzhang wrote: > lgtm. Though I wonder how can the crash ...
4 years, 5 months ago (2016-07-04 14:59:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118313002/1
4 years, 5 months ago (2016-07-04 14:59:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 15:30:27 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 15:30:32 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 15:31:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53768efa825a826a9e3273b608415cea1cfd6361
Cr-Commit-Position: refs/heads/master@{#403684}

Powered by Google App Engine
This is Rietveld 408576698