Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: test/mjsunit/regress/regress-4815.js

Issue 2118283003: [builtins] Construct builtin frame in String/Number ctors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160630-tostringtag
Patch Set: Remove TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/regress/regress-105.js ('k') | test/mjsunit/regress/regress-5173.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-4815.js
diff --git a/test/mjsunit/regress/regress-4815.js b/test/mjsunit/regress/regress-4815.js
index f6adb0169cd2a56da8fcb793e635252ce52b5a55..68764865f7c4eac20fae240254f8e5860ede5439 100644
--- a/test/mjsunit/regress/regress-4815.js
+++ b/test/mjsunit/regress/regress-4815.js
@@ -16,9 +16,6 @@ function testTraceNativeConversion(nativeFunc) {
}
}
-testTraceNativeConversion(Math.max);
-testTraceNativeConversion(Math.min);
-
// C++ builtins.
testTraceNativeConversion(Math.acos);
testTraceNativeConversion(Math.asin);
@@ -35,15 +32,6 @@ function testBuiltinInStackTrace(script, expectedString) {
}
}
-// Use the full name ('String.getDate') in order to avoid false pass
-// results when the method name is mentioned in the error message itself.
-// This occurs, e.g., for Date.prototype.getYear, which uses a different code
-// path and never hits the Generate_DatePrototype_GetField builtin.
-testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate");
-testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
- "at String.getUTCDate");
-testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime");
-
// C++ builtins.
testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);",
"at Object.toString");
@@ -52,16 +40,12 @@ testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);",
testBuiltinInStackTrace("new Date(thrower);", "at new Date");
// Ensure we correctly pick up the receiver's string tag.
-testBuiltinInStackTrace("Math.max(thrower);", "at Math.max");
-testBuiltinInStackTrace("Math.min(thrower);", "at Math.min");
testBuiltinInStackTrace("Math.acos(thrower);", "at Math.acos");
testBuiltinInStackTrace("Math.asin(thrower);", "at Math.asin");
testBuiltinInStackTrace("Math.fround(thrower);", "at Math.fround");
testBuiltinInStackTrace("Math.imul(thrower);", "at Math.imul");
// As above, but function passed as an argument and then called.
-testBuiltinInStackTrace("((f, x) => f(x))(Math.max, thrower);", "at max");
-testBuiltinInStackTrace("((f, x) => f(x))(Math.min, thrower);", "at min");
testBuiltinInStackTrace("((f, x) => f(x))(Math.acos, thrower);", "at acos");
testBuiltinInStackTrace("((f, x) => f(x))(Math.asin, thrower);", "at asin");
testBuiltinInStackTrace("((f, x) => f(x))(Math.fround, thrower);", "at fround");
« no previous file with comments | « test/mjsunit/regress/regress-105.js ('k') | test/mjsunit/regress/regress-5173.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698