Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: src/isolate.cc

Issue 2118283003: [builtins] Construct builtin frame in String/Number ctors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160630-tostringtag
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/x64/builtins-x64.cc » ('j') | src/x64/builtins-x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index afd3803e42cf10dd8b08505685906dfd237e27da..af49a159630b1b61a41cb1205570afa8ffb1cb9a 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -396,6 +396,11 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
for (int i = frames.length() - 1; i >= 0; i--) {
Handle<JSFunction> fun = frames[i].function();
Handle<Object> recv = frames[i].receiver();
+ if (frame->type() == StackFrame::BUILTIN && fun->IsConstructor()) {
+ // Help CallSite::IsConstructor to properly detect constructors
+ // implemented in assembler.
+ recv = handle(heap()->call_site_constructor_symbol(), this);
+ }
// Filter out internal frames that we do not want to show.
if (!IsVisibleInStackTrace(*fun, *caller, &seen_caller)) continue;
// Filter out frames from other security contexts.
« no previous file with comments | « no previous file | src/x64/builtins-x64.cc » ('j') | src/x64/builtins-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698