[builtins] Construct builtin frame in String/Number ctors

test/mjsunit/regress/regress-5173.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var thrower = { [Symbol.toPrimitive]: () => FAIL };
 
 // Tests that a native conversion function is included in the
 // stack trace.
 function testTraceNativeConversion(nativeFunc) {
   var nativeFuncName = nativeFunc.name;
   try {
     nativeFunc(thrower);
     assertUnreachable(nativeFuncName);
   } catch (e) {
     assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName);
   }
 }
 
 testTraceNativeConversion(Math.max);
 testTraceNativeConversion(Math.min);
 
-// C++ builtins.
-testTraceNativeConversion(Math.acos);
-testTraceNativeConversion(Math.asin);
-testTraceNativeConversion(Math.fround);
-testTraceNativeConversion(Math.imul);
-
-
 function testBuiltinInStackTrace(script, expectedString) {
   try {
     eval(script);
     assertUnreachable(expectedString);
   } catch (e) {
     assertTrue(e.stack.indexOf(expectedString) >= 0, expectedString);
   }
 }
 
-// Use the full name ('String.getDate') in order to avoid false pass
-// results when the method name is mentioned in the error message itself.
-// This occurs, e.g., for Date.prototype.getYear, which uses a different code
-// path and never hits the Generate_DatePrototype_GetField builtin.
 testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate");
 testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
                         "at String.getUTCDate");
 testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime");
 
-// C++ builtins.
-testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);",
-                        "at Object.toString");
-
-// Constructor builtins.
-testBuiltinInStackTrace("new Date(thrower);", "at new Date");
+// TODO(jgruber): These use a more generic expected string until detection of
+// assembly builtin constructors is fixed.
+testBuiltinInStackTrace("Number(thrower);", "Number");
+testBuiltinInStackTrace("new Number(thrower);", "Number");
+testBuiltinInStackTrace("String(thrower);", "String");
+testBuiltinInStackTrace("new String(thrower);", "String");
 
 // Ensure we correctly pick up the receiver's string tag.
-testBuiltinInStackTrace("Math.max(thrower);", "at Math.max");
-testBuiltinInStackTrace("Math.min(thrower);", "at Math.min");
 testBuiltinInStackTrace("Math.acos(thrower);", "at Math.acos");
 testBuiltinInStackTrace("Math.asin(thrower);", "at Math.asin");
 testBuiltinInStackTrace("Math.fround(thrower);", "at Math.fround");
 testBuiltinInStackTrace("Math.imul(thrower);", "at Math.imul");
 
 // As above, but function passed as an argument and then called.
-testBuiltinInStackTrace("((f, x) => f(x))(Math.max, thrower);", "at max");
-testBuiltinInStackTrace("((f, x) => f(x))(Math.min, thrower);", "at min");
 testBuiltinInStackTrace("((f, x) => f(x))(Math.acos, thrower);", "at acos");
 testBuiltinInStackTrace("((f, x) => f(x))(Math.asin, thrower);", "at asin");
 testBuiltinInStackTrace("((f, x) => f(x))(Math.fround, thrower);", "at fround");
 testBuiltinInStackTrace("((f, x) => f(x))(Math.imul, thrower);", "at imul");