Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2118253002: [turbofan] Mark JSStackCheck as no-write. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark JSStackCheck as no-write. This is compatible with what Crankshaft does, and therefore should be safe. The runtime doesn't perform any JavaScript-observable side effects during the stack check. R=jarin@chromium.org Committed: https://crrev.com/f3f16c09cf222f0025fa46b97305dd17556e4a12 Cr-Commit-Position: refs/heads/master@{#37501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-operator.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-04 12:31:35 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-04 12:36:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118253002/1
4 years, 5 months ago (2016-07-04 12:37:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 12:55:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 12:56:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f16c09cf222f0025fa46b97305dd17556e4a12
Cr-Commit-Position: refs/heads/master@{#37501}

Powered by Google App Engine
This is Rietveld 408576698