Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2118203002: Correct evaluation of interpolated `null` (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-04 13:34:56 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-06 15:52:21 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 07:50:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04d28ffecb81ebc44ee05745c93ce9f19e6e73c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698