Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2118173002: Make OwnedWrapper and PassedWrapper move-only (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@30_sync
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make OwnedWrapper and PassedWrapper move-only base::internal::OwnedWrapper and base::internal::PassedWrapper have std::auto_ptr style destructive copy semantics, which is no longer needed. This CL makes them move-only for saner semantics. BUG=554299 Committed: https://crrev.com/e7ed5bad1cb58022345bd4768a4a070d43c98dad Cr-Commit-Position: refs/heads/master@{#403857}

Patch Set 1 #

Patch Set 2 : fix spacing #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/bind_helpers.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tzik
PTAL
4 years, 5 months ago (2016-07-04 08:26:42 UTC) #3
Yuta Kitamura
lgtm
4 years, 5 months ago (2016-07-04 09:29:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118173002/40001
4 years, 5 months ago (2016-07-06 04:45:20 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 06:39:34 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 06:39:42 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 06:41:19 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7ed5bad1cb58022345bd4768a4a070d43c98dad
Cr-Commit-Position: refs/heads/master@{#403857}

Powered by Google App Engine
This is Rietveld 408576698