Add a disable-arc-data-wipe flag.

Add a disable-arc-data-wipe flag.

This flag prevents ARC user data from being wiped if the user has opted
out.  This is primarily intended for testing cases.

BUG=625559
TEST=Manual testing on device

Committed: https://crrev.com/874a570e4c102e07e5ef390ad2a780f1ff532677
Cr-Commit-Position: refs/heads/master@{#403841}

[dspaid, 2016-07-04 07:31:07]

dspaid@chromium.org changed reviewers:
+ yusukes@chromium.org

[Yusuke Sato, 2016-07-05 03:52:41]

lgtm

https://codereview.chromium.org/2118143003/diff/1/components/arc/user_data/ar...
File components/arc/user_data/arc_user_data_service.cc (right):

https://codereview.chromium.org/2118143003/diff/1/components/arc/user_data/ar...
components/arc/user_data/arc_user_data_service.cc:56:
chromeos::switches::kDisableArcDataWipe))
nit: can you add {}? IIUC arc/ usually uses {} when the condition is multi-line.

[dspaid, 2016-07-05 03:59:04]

https://codereview.chromium.org/2118143003/diff/1/components/arc/user_data/ar...
File components/arc/user_data/arc_user_data_service.cc (right):

https://codereview.chromium.org/2118143003/diff/1/components/arc/user_data/ar...
components/arc/user_data/arc_user_data_service.cc:56:
chromeos::switches::kDisableArcDataWipe))
On 2016/07/05 03:52:41, Yusuke Sato wrote:
> nit: can you add {}? IIUC arc/ usually uses {} when the condition is
multi-line.

Done.

[dspaid, 2016-07-05 04:05:43]

dspaid@chromium.org changed reviewers:
+ piman@chromium.org

[dspaid, 2016-07-05 04:05:43]

+piman for chrome/browser/chromeos/login OWNERS

[achuithb, 2016-07-05 08:03:37]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2016-07-05 08:03:37]

https://codereview.chromium.org/2118143003/diff/20001/chromeos/chromeos_switc...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2118143003/diff/20001/chromeos/chromeos_switc...
chromeos/chromeos_switches.cc:74: // Disable wipine android user data on opt
out.
what's wipine?

[achuithb, 2016-07-05 08:03:56]

On 2016/07/05 04:05:43, dspaid wrote:
> +piman for chrome/browser/chromeos/login OWNERS

owner lgtm since piman@ is OOO

[dspaid, 2016-07-06 01:44:31]

https://codereview.chromium.org/2118143003/diff/20001/chromeos/chromeos_switc...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2118143003/diff/20001/chromeos/chromeos_switc...
chromeos/chromeos_switches.cc:74: // Disable wipine android user data on opt
out.
On 2016/07/05 08:03:37, achuithb wrote:
> what's wipine?

A typo.

[dspaid, 2016-07-06 01:44:40]

The CQ bit was checked by dspaid@chromium.org

[dspaid, 2016-07-06 01:44:40]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2118143003/#ps20001
(title: "Add braces")

[commit-bot: I haz the power, 2016-07-06 01:44:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dspaid, 2016-07-06 01:45:10]

The CQ bit was unchecked by dspaid@chromium.org

[dspaid, 2016-07-06 01:48:36]

The CQ bit was checked by dspaid@chromium.org

[dspaid, 2016-07-06 01:48:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
achuith@chromium.org, yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2118143003/#ps40001
(title: "Add a disable-arc-data-wipe flag.")

[commit-bot: I haz the power, 2016-07-06 01:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 02:32:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 02:32:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 02:34:38]

Description was changed from

==========
Add a disable-arc-data-wipe flag.

This flag prevents ARC user data from being wiped if the user has opted
out.  This is primarily intended for testing cases.

BUG=625559
TEST=Manual testing on device
==========

to

==========
Add a disable-arc-data-wipe flag.

This flag prevents ARC user data from being wiped if the user has opted
out.  This is primarily intended for testing cases.

BUG=625559
TEST=Manual testing on device

Committed: https://crrev.com/874a570e4c102e07e5ef390ad2a780f1ff532677
Cr-Commit-Position: refs/heads/master@{#403841}
==========

[commit-bot: I haz the power, 2016-07-06 02:34:39]

Patchset 3 (id:??) landed as
https://crrev.com/874a570e4c102e07e5ef390ad2a780f1ff532677
Cr-Commit-Position: refs/heads/master@{#403841}

[piman, 2016-07-06 16:59:35]

lgtm