Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2118133002: X87: [builtins] Unify Cosh, Sinh and Tanh as exports from flibm. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Unify Cosh, Sinh and Tanh as exports from flibm. port cede9ce5e1fd4f5abad87709c559c8c7066bc6ee (r37424) original commit message: BUG= Committed: https://crrev.com/c43d5ddebad48c94a0aae2a1c5b2b58768b44939 Cr-Commit-Position: refs/heads/master@{#37491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 03:26:24 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-04 03:54:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118133002/1
4 years, 5 months ago (2016-07-04 04:05:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118133002/1
4 years, 5 months ago (2016-07-04 04:28:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4341) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-04 04:46:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118133002/1
4 years, 5 months ago (2016-07-04 05:27:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4344) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-04 05:45:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118133002/1
4 years, 5 months ago (2016-07-04 06:06:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 06:24:34 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 06:27:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c43d5ddebad48c94a0aae2a1c5b2b58768b44939
Cr-Commit-Position: refs/heads/master@{#37491}

Powered by Google App Engine
This is Rietveld 408576698