Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2118083003: Emoji modifier should be deleted at the same time in ZWJ sequence. (Closed)

Created:
4 years, 5 months ago by Seigo Nonaka
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Emoji modifier should be deleted at the same time in ZWJ sequence. Committed: https://crrev.com/3e75109d688e744341a944de11c35e652b9e06cf Cr-Commit-Position: refs/heads/master@{#403659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/state_machines/BackspaceStateMachine.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/state_machines/BackspaceStateMachineTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Seigo Nonaka
Hi Yoshi-san, could you kindly take a look? Thank you.
4 years, 5 months ago (2016-07-04 09:17:09 UTC) #4
yosin_UTC9
lgtm
4 years, 5 months ago (2016-07-04 09:48:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118083003/40001
4 years, 5 months ago (2016-07-04 09:48:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-04 10:22:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 10:23:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e75109d688e744341a944de11c35e652b9e06cf
Cr-Commit-Position: refs/heads/master@{#403659}

Powered by Google App Engine
This is Rietveld 408576698