Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: services/tracing/tracing_app.h

Issue 2118083002: ShellClient -> Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mus2
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/tests/util.cc ('k') | services/tracing/tracing_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/tracing/tracing_app.h
diff --git a/services/tracing/tracing_app.h b/services/tracing/tracing_app.h
index 6ba6bfd49ad64f783092a89d3d45f8ddcb5a0467..9fea6e1fd6a9cdb37f117464398bb68732b118cf 100644
--- a/services/tracing/tracing_app.h
+++ b/services/tracing/tracing_app.h
@@ -15,7 +15,7 @@
#include "mojo/public/cpp/bindings/interface_ptr_set.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/shell/public/cpp/interface_factory.h"
-#include "services/shell/public/cpp/shell_client.h"
+#include "services/shell/public/cpp/service.h"
#include "services/tracing/public/interfaces/tracing.mojom.h"
#include "services/tracing/trace_data_sink.h"
#include "services/tracing/trace_recorder_impl.h"
@@ -23,7 +23,7 @@
namespace tracing {
class TracingApp
- : public shell::ShellClient,
+ : public shell::Service,
public shell::InterfaceFactory<TraceCollector>,
public TraceCollector,
public shell::InterfaceFactory<StartupPerformanceDataCollector>,
@@ -33,9 +33,9 @@ class TracingApp
~TracingApp() override;
private:
- // shell::ShellClient implementation.
- bool AcceptConnection(shell::Connection* connection) override;
- bool ShellConnectionLost() override;
+ // shell::Service implementation.
+ bool OnConnect(shell::Connection* connection) override;
+ bool OnStop() override;
// shell::InterfaceFactory<TraceCollector> implementation.
void Create(shell::Connection* connection,
« no previous file with comments | « services/shell/tests/util.cc ('k') | services/tracing/tracing_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698