Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2118083002: ShellClient -> Service (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, rjkroege, hidehiko+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, lhchavez+watch_chromium.org, piman+watch_chromium.org, ben+mojo_chromium.org, qsr+mojo_chromium.org, tapted, Matt Giuca, lcwu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, oshima+watch_chromium.org, alokp+watch_chromium.org, jochen+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, tfarina, Aaron Boodman, davemoore+watch_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShellClient -> Service TBR=rockot@chromium.org,tsepez@chromium.org http://crbug.com/625840 Committed: https://crrev.com/e1bbc001243f13dd3197333cc6d7ea9e02199566 Cr-Commit-Position: refs/heads/master@{#403786}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1066 lines, -1151 lines) Patch
M ash/mus/window_manager_application.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/sysui/sysui_application.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/sysui/sysui_application.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/mash/mash_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 6 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/mojo_test_connector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 2 3 4 5 5 chunks +9 lines, -9 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.h View 3 chunks +8 lines, -7 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/font_service/font_service_app.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 chunk +7 lines, -7 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/browser_context.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/process_control_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/process_control_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mojo/embedded_application_runner.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/common/mojo/embedded_application_runner.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 3 chunks +23 lines, -24 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 8 chunks +31 lines, -31 lines 0 comments Download
M content/common/process_control.mojom View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/mojo_application_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/common/mojo_application_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/mojo_shell_connection.h View 4 chunks +16 lines, -17 lines 0 comments Download
M content/public/test/test_mojo_app.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/utility/content_utility_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/unix_domain_socket_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/unix_domain_socket_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/app_driver/app_driver.h View 2 chunks +8 lines, -8 lines 0 comments Download
M mash/app_driver/app_driver.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mash/browser/browser.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/browser/browser.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/init/init.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/init/init.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/login/login.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/login/login.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mash/screenlock/screenlock.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mash/screenlock/screenlock.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/session/session.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/session/session.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/webtest/webtest.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/webtest/webtest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 3 chunks +8 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/catalog.h View 5 chunks +8 lines, -8 lines 0 comments Download
M services/catalog/catalog.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/navigation/content_client/content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/navigation.h View 3 chunks +7 lines, -7 lines 0 comments Download
M services/navigation/navigation.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/navigation/navigation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/background_shell.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/background/background_shell.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M services/shell/background/tests/background_shell_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M services/shell/background/tests/test_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M services/shell/native_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/application_runner.h View 3 chunks +3 lines, -3 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/connector.h View 3 chunks +6 lines, -6 lines 0 comments Download
M services/shell/public/cpp/lib/application_runner.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A services/shell/public/cpp/lib/service.cc View 1 chunk +30 lines, -0 lines 0 comments Download
D services/shell/public/cpp/lib/shell_client.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M services/shell/public/cpp/lib/shell_connection.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M services/shell/public/cpp/lib/shell_connection_ref.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M services/shell/public/cpp/lib/shell_test.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M services/shell/public/cpp/names.h View 1 chunk +2 lines, -2 lines 0 comments Download
A services/shell/public/cpp/service.h View 1 chunk +64 lines, -0 lines 0 comments Download
D services/shell/public/cpp/shell_client.h View 1 chunk +0 lines, -63 lines 0 comments Download
M services/shell/public/cpp/shell_connection.h View 4 chunks +23 lines, -23 lines 0 comments Download
M services/shell/public/cpp/shell_test.h View 4 chunks +20 lines, -20 lines 0 comments Download
M services/shell/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/interfaces/connector.mojom View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + services/shell/public/interfaces/service.mojom View 3 chunks +8 lines, -8 lines 0 comments Download
A services/shell/public/interfaces/service_factory.mojom View 1 chunk +13 lines, -0 lines 0 comments Download
D services/shell/public/interfaces/shell_client.mojom View 1 chunk +0 lines, -78 lines 0 comments Download
D services/shell/public/interfaces/shell_client_factory.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
M services/shell/runner/child/test_native_main.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/runner/child/test_native_main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M services/shell/runner/common/client_util.h View 2 chunks +9 lines, -9 lines 0 comments Download
M services/shell/runner/common/client_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M services/shell/runner/host/child_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/child_process_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/shell/runner/host/child_process_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/child_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/child_process_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/native_application_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/native_application_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/out_of_process_native_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/out_of_process_native_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/shell.h View 7 chunks +19 lines, -19 lines 0 comments Download
M services/shell/shell.cc View 17 chunks +66 lines, -67 lines 0 comments Download
M services/shell/shell_public.gyp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M services/shell/standalone/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/connect/connect_test_driver.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M services/shell/tests/connect/connect_test_exe.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 6 chunks +38 lines, -38 lines 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/app_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/lifecycle_exe.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/package.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M services/shell/tests/lifecycle/parent.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M services/shell/tests/shell/driver.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M services/shell/tests/shell/shell_unittest.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M services/shell/tests/shell/target.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_client_app.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_service_app.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/tracing/tracing_app.h View 3 chunks +5 lines, -5 lines 0 comments Download
M services/tracing/tracing_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/demo/mus_demo.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_shelltest_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_shelltest_base.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/service.h View 3 chunks +7 lines, -7 lines 0 comments Download
M services/ui/service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/user/user_shell_client.h View 2 chunks +8 lines, -8 lines 0 comments Download
M services/user/user_shell_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-07-05 14:40:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118083002/120001
4 years, 5 months ago (2016-07-05 14:41:28 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-05 16:04:53 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 16:04:59 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 16:06:18 UTC) #11
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/e1bbc001243f13dd3197333cc6d7ea9e02199566
Cr-Commit-Position: refs/heads/master@{#403786}

Powered by Google App Engine
This is Rietveld 408576698