Issue 2118033002: fix for Clang 3.8 warning in SkSL

Issue 2118033002: fix for Clang 3.8 warning in SkSL (Closed)

Created:
4 years, 5 months ago by ethannicholas

Modified:
4 years, 5 months ago

Reviewers:
csmartdalton

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/sksl/SkSLParser.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Dependent Patchsets:

Total messages: 12 (6 generated)

ethannicholas

Can you see if this fixes the SkSL warning you are running into?

4 years, 5 months ago (2016-07-02 12:32:34 UTC) #3

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118033002/1

4 years, 5 months ago (2016-07-02 12:35:00 UTC) #5

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 5 months ago (2016-07-02 12:48:54 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118033002/1

4 years, 5 months ago (2016-07-06 13:24:40 UTC) #10

commit-bot: I haz the power

4 years, 5 months ago (2016-07-06 13:55:47 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e5a588ab3fc7268e7750009484dbe1d0742b1c2