Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 21180008: Update Array Iterator to use numeric indexes (Closed)

Created:
7 years, 4 months ago by arv (Not doing code reviews)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update Array Iterator to use numeric indexes At the last face-to-face meeting it was decided that we should use numeric indexes for the Array Iterator values. https://github.com/rwldrn/tc39-notes/blob/master/es6/2013-07/july-24.md#514-keys-entries-return-numbers-for-array-index-properties BUG=v8:2818 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/array-iterator.js View 1 chunk +3 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/array-iterator.js View 7 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
7 years, 4 months ago (2013-07-31 20:52:29 UTC) #1
Michael Starzinger
I'll leave this one to Andreas. He will be back on Monday.
7 years, 4 months ago (2013-08-01 08:11:24 UTC) #2
arv (Not doing code reviews)
Adding Dmitry who was there at the F2F
7 years, 4 months ago (2013-08-01 13:50:49 UTC) #3
rossberg
Looks fine to me, but I'll let Dmitry decide, since I'm still in catch-up mode ...
7 years, 4 months ago (2013-08-06 08:29:33 UTC) #4
Dmitry Lomov (no reviews)
lgtm
7 years, 4 months ago (2013-08-06 11:34:42 UTC) #5
Dmitry Lomov (no reviews)
On 2013/08/06 11:34:42, Dmitry Lomov (chromium) wrote: > lgtm (I'll land)
7 years, 4 months ago (2013-08-06 13:03:29 UTC) #6
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-08-06 13:10:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r16072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698