Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Side by Side Diff: test/mjsunit/math-abs.js

Issue 21180004: Avoid redundant smi check for Math.abs (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 function foo(x) { 102 function foo(x) {
103 return Math.abs(x); 103 return Math.abs(x);
104 } 104 }
105 // Get some smi type feedback. 105 // Get some smi type feedback.
106 for(var i = 0; i < 1000; i++) { 106 for(var i = 0; i < 1000; i++) {
107 foo(-i); 107 foo(-i);
108 } 108 }
109 assertEquals(42, foo(-42)); 109 assertEquals(42, foo(-42));
110 %OptimizeFunctionOnNextCall(foo) 110 %OptimizeFunctionOnNextCall(foo)
111 assertEquals(42, foo(-42)); 111 assertEquals(42, foo(-42));
112
113 // Regression test for SMI input of Math.abs on X64, see:
114 // https://codereview.chromium.org/21180004/
115 var a = [-1, -2];
116 function foo2() {
117 return Math.abs(a[0]);
118 }
119 assertEquals(1, foo2());
120 assertEquals(1, foo2());
121 %OptimizeFunctionOnNextCall(foo2);
122 assertEquals(1, foo2());
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698