Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 21180004: Avoid redundant smi check for Math.abs (Closed)

Created:
7 years, 4 months ago by weiliang.lin2
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Avoid redundant smi check for Math.abs R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16021

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/mjsunit/math-abs.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
weiliang.lin2
The original commit is https://codereview.chromium.org/21210002/ Hi Jakob, Sorry for using another commit entry because I ...
7 years, 4 months ago (2013-07-31 14:27:51 UTC) #1
Jakob Kummerow
LGTM, I'll land. Next time, when you accidentally delete a local git branch, you can ...
7 years, 4 months ago (2013-08-01 11:33:38 UTC) #2
weiliang.lin2
On 2013/08/01 11:33:38, Jakob wrote: > LGTM, I'll land. > > Next time, when you ...
7 years, 4 months ago (2013-08-01 13:11:57 UTC) #3
weiliang.lin2
On 2013/08/01 11:33:38, Jakob wrote: > LGTM, I'll land. > > Next time, when you ...
7 years, 4 months ago (2013-08-01 13:21:53 UTC) #4
Jakob Kummerow
7 years, 4 months ago (2013-08-02 08:59:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698