|
|
Created:
4 years, 5 months ago by Ryan Tseng Modified:
4 years, 5 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionAdd cipd binary support to cit.py
BUG=
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9a0de0b9f1249b128ac0fd1d3800f5a8c9a921ad
Patch Set 1 #
Total comments: 2
Patch Set 2 : Stderr #Patch Set 3 : Actually do it #Messages
Total messages: 30 (17 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hinoka@google.com changed reviewers: + dnj@chromium.org, tandrii@chromium.org
Since you're making cipd tools now, you might find this handy +tandrii since he's been poking at cit.py a bit too
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dnj@google.com changed reviewers: + dnj@google.com
lgtm
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
LGTM for cipd changes, but please keep stderr writing. https://codereview.chromium.org/2117943002/diff/1/cit.py File cit.py (left): https://codereview.chromium.org/2117943002/diff/1/cit.py#oldcode62 cit.py:62: sys.stderr.flush() you really don't like my stderr writing :( the purpose of it was to avoid polluting stdout so that "cit log" output can be piped without hackery of skipping first line. The real fix would be to use logging with proper levels of verbosity.
Stderr
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Actually do it
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hinoka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com, tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/2117943002/#ps40001 (title: "Actually do it")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add cipd binary support to cit.py BUG= ========== to ========== Add cipd binary support to cit.py BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9a0de0b9f1249b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/9a0de0b9f1249b...
Message was sent while issue was closed.
On 2016/07/14 19:43:57, Ryan Tseng wrote: > Actually do it Thanks!
Message was sent while issue was closed.
https://codereview.chromium.org/2117943002/diff/1/cit.py File cit.py (left): https://codereview.chromium.org/2117943002/diff/1/cit.py#oldcode62 cit.py:62: sys.stderr.flush() On 2016/07/14 12:59:26, tandrii(chromium) wrote: > you really don't like my stderr writing :( > the purpose of it was to avoid polluting stdout so that "cit log" output can be > piped without hackery of skipping first line. > > The real fix would be to use logging with proper levels of verbosity. Oops I think this was a mistake, or I rebased badly. |