Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2117943002: Add cipd binary support to cit.py (Closed)

Created:
4 years, 5 months ago by Ryan Tseng
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Stderr #

Patch Set 3 : Actually do it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M cit.py View 1 2 2 chunks +45 lines, -11 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117943002/1
4 years, 5 months ago (2016-07-01 21:59:59 UTC) #2
Ryan Tseng
Since you're making cipd tools now, you might find this handy +tandrii since he's been ...
4 years, 5 months ago (2016-07-01 22:00:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 22:03:59 UTC) #6
dnj (Google)
lgtm
4 years, 5 months ago (2016-07-01 22:42:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117943002/1
4 years, 5 months ago (2016-07-01 22:44:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/745)
4 years, 5 months ago (2016-07-01 22:50:58 UTC) #12
tandrii(chromium)
LGTM for cipd changes, but please keep stderr writing. https://codereview.chromium.org/2117943002/diff/1/cit.py File cit.py (left): https://codereview.chromium.org/2117943002/diff/1/cit.py#oldcode62 cit.py:62: ...
4 years, 5 months ago (2016-07-14 12:59:26 UTC) #13
Ryan Tseng
Stderr
4 years, 5 months ago (2016-07-14 19:38:08 UTC) #14
Ryan Tseng
Actually do it
4 years, 5 months ago (2016-07-14 19:43:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117943002/40001
4 years, 5 months ago (2016-07-14 19:56:47 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/9a0de0b9f1249b128ac0fd1d3800f5a8c9a921ad
4 years, 5 months ago (2016-07-14 20:00:04 UTC) #28
tandrii(chromium)
On 2016/07/14 19:43:57, Ryan Tseng wrote: > Actually do it Thanks!
4 years, 5 months ago (2016-07-14 20:02:18 UTC) #29
Ryan Tseng
4 years, 5 months ago (2016-07-14 20:27:11 UTC) #30
Message was sent while issue was closed.
https://codereview.chromium.org/2117943002/diff/1/cit.py
File cit.py (left):

https://codereview.chromium.org/2117943002/diff/1/cit.py#oldcode62
cit.py:62: sys.stderr.flush()
On 2016/07/14 12:59:26, tandrii(chromium) wrote:
> you really don't like my stderr writing :(
> the purpose of it was to avoid polluting stdout so that "cit log" output can
be
> piped without hackery of skipping first line.
> 
> The real fix would be to use logging with proper levels of verbosity.

Oops I think this was a mistake, or I rebased badly.

Powered by Google App Engine
This is Rietveld 408576698