Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2117853003: Revert of [heap] Reland uncommit unused large object page memory. (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Reland uncommit unused large object page memory. (patchset #4 id:60001 of https://codereview.chromium.org/2109943003/ ) Reason for revert: Caused crashes on Canary Original issue's description: > [heap] Reland uncommit unused large object page memory. > > BUG= > > Committed: https://crrev.com/46a365faae01636c48412662a1befe551a71be6e > Cr-Commit-Position: refs/heads/master@{#37376} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:624790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -207 lines) Patch
M src/base/hashmap.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/base/platform/platform.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +1 line, -13 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +21 lines, -89 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D test/mjsunit/regress/regress-617882.js View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
Created Revert of [heap] Reland uncommit unused large object page memory.
4 years, 5 months ago (2016-07-01 18:17:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117853003/1
4 years, 5 months ago (2016-07-01 18:18:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/4269) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-01 18:19:30 UTC) #6
ulan
On 2016/07/01 18:18:20, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-01 18:21:04 UTC) #7
adamk
4 years, 5 months ago (2016-07-01 18:43:20 UTC) #8
Ah, didn't see the fix, closing this.

Powered by Google App Engine
This is Rietveld 408576698