Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2117833003: endpoints -> webapp2 adapter (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

endpoints -> webapp2 adapter Add a function that converts a Cloud Endpoints service class to a list of webapp2 routes. Add a base class for tests. The test code for classic cloud endpoints can be left intact, except call_should_fail function is properly deprecated. Had to change auto_stub so it is usable in infra.git R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/3bbf5d54a875e637f9c2aa0a3be577aeef1effc3

Patch Set 1 #

Patch Set 2 : decode bool field #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -4 lines) Patch
A appengine/components/components/endpoints_webapp2.py View 1 1 chunk +132 lines, -0 lines 2 comments Download
M appengine/components/test_support/test_case.py View 2 chunks +59 lines, -0 lines 0 comments Download
M appengine/components/test_support/test_env.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/third_party_local/depot_tools/README.swarming View 1 chunk +3 lines, -1 line 0 comments Download
M appengine/third_party_local/depot_tools/auto_stub.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
nodir
PTAL All buildbucket tests pass and it is deployed to https://4673-4ebc706-tainted-nodir-dot-cr-buildbucket-dev.appspot.com e.g. https://4673-4ebc706-tainted-nodir-dot-cr-buildbucket-dev.appspot.com/api/buildbucket/v1/search?bucket=nodir
4 years, 5 months ago (2016-07-02 00:13:29 UTC) #1
nodir
On 2016/07/02 00:13:29, nodir wrote: > PTAL > > All buildbucket tests pass and it ...
4 years, 5 months ago (2016-07-06 15:49:00 UTC) #2
nodir
vadimsh is OOO +dnj
4 years, 5 months ago (2016-07-07 18:31:16 UTC) #4
dnj
lgtm
4 years, 5 months ago (2016-07-07 18:50:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117833003/20001
4 years, 5 months ago (2016-07-07 19:15:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117833003/20001
4 years, 5 months ago (2016-07-07 19:17:08 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 19:19:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117833003/20001
4 years, 5 months ago (2016-07-07 19:38:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/3bbf5d54a875e637f9c2aa0a3be577aeef1effc3
4 years, 5 months ago (2016-07-07 19:40:32 UTC) #17
Vadim Sh.
https://codereview.chromium.org/2117833003/diff/20001/appengine/components/components/endpoints_webapp2.py File appengine/components/components/endpoints_webapp2.py (right): https://codereview.chromium.org/2117833003/diff/20001/appengine/components/components/endpoints_webapp2.py#newcode111 appengine/components/components/endpoints_webapp2.py:111: return template huh?
4 years, 5 months ago (2016-07-10 14:12:08 UTC) #18
nodir
4 years, 5 months ago (2016-07-12 16:11:52 UTC) #19
Message was sent while issue was closed.
https://codereview.chromium.org/2117833003/diff/20001/appengine/components/co...
File appengine/components/components/endpoints_webapp2.py (right):

https://codereview.chromium.org/2117833003/diff/20001/appengine/components/co...
appengine/components/components/endpoints_webapp2.py:111: return template
On 2016/07/10 14:12:08, Vadim Sh. wrote:
> huh?

https://codereview.chromium.org/2142093002/

Powered by Google App Engine
This is Rietveld 408576698