Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2117813002: Add a few missing &s. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
hans
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a few missing &s. Without this, gfx::Transform is copied at calling sites, which requires its copy ctor, which requires SkMatrix44's copy ctor -- but we don't want everyone using this object having to have to depend on skia. BUG=625175 Committed: https://crrev.com/629e39e4149fd8dbe730bf27d7851d21969fff94 Cr-Commit-Position: refs/heads/master@{#403468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/gl/ca_renderer_layer_params.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gl/ca_renderer_layer_params.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
4 years, 5 months ago (2016-07-01 15:42:52 UTC) #2
hans
lgtm
4 years, 5 months ago (2016-07-01 15:43:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117813002/1
4 years, 5 months ago (2016-07-01 15:46:33 UTC) #5
kirr
On 2016/07/01 15:42:52, Nico wrote: Thanks. Sorry for this.
4 years, 5 months ago (2016-07-01 15:47:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 16:40:13 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 16:40:14 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 16:42:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/629e39e4149fd8dbe730bf27d7851d21969fff94
Cr-Commit-Position: refs/heads/master@{#403468}

Powered by Google App Engine
This is Rietveld 408576698