Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2117793002: Try fix the mac build bot after removing Android SampleApp (Closed)

Created:
4 years, 5 months ago by liyuqian
Modified:
4 years, 5 months ago
Reviewers:
rmistry, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try fix the mac build bot after removing Android SampleApp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117793002 Committed: https://skia.googlesource.com/skia/+/97a0918715b621183647d96dbe8fd2eb038ed564

Patch Set 1 #

Patch Set 2 : Try fix the build bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1563 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M gyp/everything.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/most.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/views/SkOSWindow_Android.h View 1 chunk +0 lines, -53 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
D platform_tools/android/apps/sample_app/build.gradle View 1 chunk +0 lines, -30 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 1 chunk +0 lines, -251 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 1 chunk +0 lines, -310 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 1 chunk +0 lines, -34 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 1 chunk +0 lines, -164 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +0 lines, -356 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 1 chunk +0 lines, -75 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
liyuqian
I think that I've fixed the build bot by adding vulkan condition which essentially removes ...
4 years, 5 months ago (2016-07-01 15:56:00 UTC) #4
liyuqian
I think this fixes the problem in 2104453002. Shall I land it?
4 years, 5 months ago (2016-07-06 13:51:59 UTC) #5
rmistry
On 2016/07/06 13:51:59, liyuqian wrote: > I think this fixes the problem in 2104453002. Shall ...
4 years, 5 months ago (2016-07-06 13:58:04 UTC) #6
djsollen
lgtm
4 years, 5 months ago (2016-07-06 14:20:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117793002/20001
4 years, 5 months ago (2016-07-06 14:29:32 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:52:13 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/97a0918715b621183647d96dbe8fd2eb038ed564

Powered by Google App Engine
This is Rietveld 408576698