Rename updateStyle to updateRenderTree

Rename updateStyle to updateRenderTree

updateStyle was doing too many things, this patch moves the style updating
logic out into a new function called updateStyle and renames the original
one to updateRenderTree. It also renames all the other updateStyle related
things to be named with "updateRenderTree".

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170012

[eseidel, 2014-03-25 21:31:10]

I like the idea.  I'm not sure what "updateRenderTree" does, nor am I sure what
calling "recalc style" from other parts of the code will now do.

[esprehn, 2014-03-25 21:31:56]

On 2014/03/25 21:31:10, eseidel wrote:
> I like the idea.  I'm not sure what "updateRenderTree" does, nor am I sure
what
> calling "recalc style" from other parts of the code will now do.

It updates the render tree to be in a consistent state for all the steps you see
inside that function. Do you have a better name?

[ojan, 2014-03-25 23:39:11]

While I agree that these aren't the best names, I think they're an improvement,
and with a bit of brainstorming, we weren't able to come up with something
better.

lgtm once you address the comments.

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h#n...
Source/core/dom/Document.h:478: void updateStyleForNodeIfNeeded(Node*);
Shouldn't these two also be renamed?

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h#n...
Source/core/dom/Document.h:1091: void updateStyle(StyleRecalcChange);
Can this be private now?

[esprehn, 2014-03-25 23:51:13]

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h#n...
Source/core/dom/Document.h:478: void updateStyleForNodeIfNeeded(Node*);
On 2014/03/25 23:39:11, ojan wrote:
> Shouldn't these two also be renamed?

Sure, I didn't want to touch so many files, but I can do that in this patch too.

https://codereview.chromium.org/211773002/diff/1/Source/core/dom/Document.h#n...
Source/core/dom/Document.h:1091: void updateStyle(StyleRecalcChange);
On 2014/03/25 23:39:11, ojan wrote:
> Can this be private now?

It is private, this whole block is.

[esprehn, 2014-03-26 00:35:43]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-26 00:35:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/211773002/90001

[commit-bot: I haz the power, 2014-03-26 01:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 01:13:56]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[esprehn, 2014-03-26 01:25:32]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-26 01:25:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/211773002/90001

[commit-bot: I haz the power, 2014-03-26 01:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 01:27:13]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[esprehn, 2014-03-26 01:39:55]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-26 01:40:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/211773002/170003

[commit-bot: I haz the power, 2014-03-26 02:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:54:32]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-26 02:56:06]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:56:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/211773002/170003

[commit-bot: I haz the power, 2014-03-26 04:02:57]

Change committed as 170012

[eseidel, 2014-03-26 06:33:16]

I think if we get away from other parts of blink calling these manual "update"
methods directly, then I don't care what they're named. :)  These are phase
transition methods and we should have a central authortity who you call and say
"ensureThroughPhase(Style)", etc.

Right now we're in a confusing state where everyone calls these manual methods
and we just renamed one of the manual methods from its historic name.

[ojan, 2014-03-26 17:03:48]

On 2014/03/26 06:33:16, eseidel wrote:
> I think if we get away from other parts of blink calling these manual "update"
> methods directly, then I don't care what they're named. :)  These are phase
> transition methods and we should have a central authortity who you call and
say
> "ensureThroughPhase(Style)", etc.

Totally.

> Right now we're in a confusing state where everyone calls these manual methods
> and we just renamed one of the manual methods from its historic name.

Yup. The thing is that what this method does has changed a lot in the past few
months (e.g. doing Shadow DOM distribution), so the historic name was especially
misleading.