printing/printed_document.cc - Issue 2117713002: Print directly to CUPS using the IPP APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printed_document.cc

Issue 2117713002: Print directly to CUPS using the IPP APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ippRead

Patch Set: Loggin cleaned up Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/printed_document.cc

diff --git a/printing/printed_document.cc b/printing/printed_document.cc

index f77b135f2f8de659805b3984ef3d95d67885d4fd..83c34aaf639005f366158cf1cdfbca2de4452e74 100644

--- a/printing/printed_document.cc

+++ b/printing/printed_document.cc

@@ -263,7 +263,7 @@ PrintedDocument::Immutable::Immutable(const PrintSettings& settings,

PrintedDocument::Immutable::~Immutable() {

}

-#if defined(OS_CHROMEOS) || defined(OS_ANDROID)

+#if defined(OS_ANDROID)

// This function is not used on aura linux/chromeos or android.

Lei Zhang 2016/07/08 01:35:26 Comment is out of date.

skau 2016/07/09 00:28:33 Are there aura tests to verify that I haven't brok

Lei Zhang 2016/07/13 01:43:05 If you put a NOTREACHED() in the body, we can see

skau 2016/07/14 23:47:12 Done.

void PrintedDocument::RenderPrintedPage(const PrintedPage& page,

PrintingContext* context) const {