Print directly to CUPS using the IPP APIs

printing/metafile.h

Index: printing/metafile.h
diff --git a/printing/metafile.h b/printing/metafile.h
index e93ffd10f60fd7b1e2435903448484f49e09edf5..2ae9ad2db0c7591d88ffe383aed96079794d7700 100644
--- a/printing/metafile.h
+++ b/printing/metafile.h
@@ -86,6 +86,12 @@ class PRINTING_EXPORT MetafilePlayer {
                           const MacRenderPageParams& params) const = 0;
 #endif  // if defined(OS_WIN)
 
+#if defined(OS_CHROMEOS)
+  // Populates the buffer with the underlying data. This function should ONLY be
+  // called after the metafile is closed. Returns true if writing succeeded.
+  virtual bool GetDataAsVector(std::vector<char>* buffer) const = 0;
+#endif  // defined(OS_CHROMEOS)
+
   // Saves the underlying data to the given file. This function should ONLY be
   // called after the metafile is closed. Returns true if writing succeeded.
   virtual bool SaveTo(base::File* file) const = 0;
@@ -155,7 +161,11 @@ class PRINTING_EXPORT Metafile : public MetafilePlayer {
                         const RECT* rect) const = 0;
 #endif  // OS_WIN
 
+#if defined(OS_CHROMEOS)
+  bool GetDataAsVector(std::vector<char>* buffer) const override;
+#else
   bool GetDataAsVector(std::vector<char>* buffer) const;

[Lei Zhang, 2016/07/20 01:26:56]

This feels a bit weird. Why don't we just remove the OS_CHROME ifdefs? I think
that's cleaner, even it it adds an extra method that does not get used on other
platforms.

[skau, 2016/07/22 23:36:13]

It happens that there's a Windows implementation of MetafilePlayer.  But I'll go
implement it there.

+#endif  // defined(OS_CHROMEOS)
 
   bool SaveTo(base::File* file) const override;