Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/objects.cc

Issue 21177003: Fix stale unhandlified value in JSObject::SetPropertyForResult. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3930 matching lines...) Expand 10 before | Expand all | Expand 10 after
3941 break; 3941 break;
3942 } 3942 }
3943 case HANDLER: 3943 case HANDLER:
3944 case NONEXISTENT: 3944 case NONEXISTENT:
3945 UNREACHABLE(); 3945 UNREACHABLE();
3946 } 3946 }
3947 3947
3948 Handle<Object> hresult; 3948 Handle<Object> hresult;
3949 if (!result->ToHandle(&hresult, isolate)) return result; 3949 if (!result->ToHandle(&hresult, isolate)) return result;
3950 3950
3951 if (FLAG_harmony_observation && map()->is_observed()) { 3951 if (FLAG_harmony_observation && self->map()->is_observed()) {
3952 if (lookup->IsTransition()) { 3952 if (lookup->IsTransition()) {
3953 EnqueueChangeRecord(self, "new", name, old_value); 3953 EnqueueChangeRecord(self, "new", name, old_value);
3954 } else { 3954 } else {
3955 LookupResult new_lookup(isolate); 3955 LookupResult new_lookup(isolate);
3956 self->LocalLookup(*name, &new_lookup, true); 3956 self->LocalLookup(*name, &new_lookup, true);
3957 if (new_lookup.IsDataProperty()) { 3957 if (new_lookup.IsDataProperty()) {
3958 Handle<Object> new_value = Object::GetProperty(self, name); 3958 Handle<Object> new_value = Object::GetProperty(self, name);
3959 if (!new_value->SameValue(*old_value)) { 3959 if (!new_value->SameValue(*old_value)) {
3960 EnqueueChangeRecord(self, "updated", name, old_value); 3960 EnqueueChangeRecord(self, "updated", name, old_value);
3961 } 3961 }
(...skipping 12010 matching lines...) Expand 10 before | Expand all | Expand 10 after
15972 15972
15973 void PropertyCell::AddDependentCode(Handle<Code> code) { 15973 void PropertyCell::AddDependentCode(Handle<Code> code) {
15974 Handle<DependentCode> codes = DependentCode::Insert( 15974 Handle<DependentCode> codes = DependentCode::Insert(
15975 Handle<DependentCode>(dependent_code()), 15975 Handle<DependentCode>(dependent_code()),
15976 DependentCode::kPropertyCellChangedGroup, code); 15976 DependentCode::kPropertyCellChangedGroup, code);
15977 if (*codes != dependent_code()) set_dependent_code(*codes); 15977 if (*codes != dependent_code()) set_dependent_code(*codes);
15978 } 15978 }
15979 15979
15980 15980
15981 } } // namespace v8::internal 15981 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698