Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2117693002: Fix crash issues if there is no resources pack in content shell

Created:
4 years, 5 months ago by HyungwookLee
Modified:
4 years, 4 months ago
Reviewers:
rnimmagadda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash issues if there is no resources pack in content shell There are some place where do not consider no resources pack condition. BUG=625008 R=rnimmagadda@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M services/catalog/reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/resource/data_pack.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
HyungwookLee
PTAL.
4 years, 5 months ago (2016-07-01 01:11:11 UTC) #3
HyungwookLee
PTAL.
4 years, 5 months ago (2016-07-08 11:42:10 UTC) #5
dschuyler
4 years, 4 months ago (2016-08-02 02:46:40 UTC) #8 
On 2016/08/01 01:03:48, HyungwookLee wrote:
> mailto:hyungwook.lee@navercorp.com changed reviewers:
> + mailto:dschuyler@chromium.org
> - mailto:maruel@chromium.org

Hi HyungwookLee,

Thanks for submitting a patch. I see that you've been changing reviewers.
I'm guessing you're looking for an owner to approve it. My entry in the 
OWNERS file is only for files that start with "template_expressions". That's
what this line in the OWNERS file means:

per-file template_expressions*=dschuyler@chromium.org

So I wouldn't be able to approve it. Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698