Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2117663002: [Reland] Remove style spans to follow the styles of the block element (Closed)

Created:
2 years ago by joone
Modified:
2 years ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Remove style spans to follow the styles of the block element Note: The original CL was reverted because of breaking Win8 build: https://codereview.chromium.org/2109973002/ This CL removes style spans to follow the styles of the block element(li, pre, td, and h1~6) when the text of the pasted or merged element becomes a part of the block element. BUG=226941 TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html Committed: https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0 Cr-Commit-Position: refs/heads/master@{#403428}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
joone
Hi yosin@ I fixed the Win8 build break by updating the code as follows: @@ ...
2 years ago (2016-07-01 01:16:00 UTC) #3
yosin_UTC9
lgtm lgtm I'm wander why CQ catches this...
2 years ago (2016-07-01 08:53:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117663002/1
2 years ago (2016-07-01 08:53:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years ago (2016-07-01 08:59:43 UTC) #8
commit-bot: I haz the power
2 years ago (2016-07-01 09:01:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0
Cr-Commit-Position: refs/heads/master@{#403428}

Powered by Google App Engine
This is Rietveld 408576698