Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2117663002: [Reland] Remove style spans to follow the styles of the block element (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 months ago by joone
Modified:
12 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Remove style spans to follow the styles of the block element Note: The original CL was reverted because of breaking Win8 build: https://codereview.chromium.org/2109973002/ This CL removes style spans to follow the styles of the block element(li, pre, td, and h1~6) when the text of the pasted or merged element becomes a part of the block element. BUG=226941 TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html Committed: https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0 Cr-Commit-Position: refs/heads/master@{#403428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -41 lines) Patch
A third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html View 1 chunk +36 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 3 chunks +31 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 10 (5 generated)
joone
Hi yosin@ I fixed the Win8 build break by updating the code as follows: @@ ...
12 months ago (2016-07-01 01:16:00 UTC) #3
yosin_UTC9
lgtm lgtm I'm wander why CQ catches this...
12 months ago (2016-07-01 08:53:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117663002/1
12 months ago (2016-07-01 08:53:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
12 months ago (2016-07-01 08:59:43 UTC) #8
commit-bot: I haz the power
12 months ago (2016-07-01 09:01:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0
Cr-Commit-Position: refs/heads/master@{#403428}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589