[Reland] Remove style spans to follow the styles of the block element

[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html

Committed: https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0
Cr-Commit-Position: refs/heads/master@{#403428}

[joone, 2016-07-01 00:41:02]

Description was changed from

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of beaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
==========

to

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
==========

[joone, 2016-07-01 01:15:59]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-07-01 01:16:00]

Hi yosin@

I fixed the Win8 build break by updating the code as follows:

@@ -833,7 +833,8 @@ static bool
handleStyleSpansBeforeInsertion(ReplacementFragment& fragment, const       
     // e.g.) editing/execCommand/switch-list-type.html                         
                          
     //       editing/deleting/backspace-merge-into-block.html                  
                          
     if (node->computedStyle()->display() == INLINE) {                          
                          
-        if (!(node = enclosingBlock(insertionPos.anchorNode())))               
                          
+        node = enclosingBlock(insertionPos.anchorNode());                      
                          
+        if (!node)                                                             
                          
             return false;                                                      
                          
     }                                                                          
                          
                                                                                
                          

FYI, this is the Win8 build error message:
c:\git\chromium\src\third_party\webkit\source\core\editing\commands\replaceselectioncommand.cpp(836)
: error C2220: warning treated as error - no 'object' file generated
c:\git\chromium\src\third_party\webkit\source\core\editing\commands\replaceselectioncommand.cpp(836)
: warning C4706: assignment within conditional expression

Thanks!

[yosin_UTC9, 2016-07-01 08:53:32]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-01 08:53:33]

lgtm

lgtm

I'm wander why CQ catches this...

[commit-bot: I haz the power, 2016-07-01 08:53:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 08:59:43]

Description was changed from

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
==========

to

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
==========

[commit-bot: I haz the power, 2016-07-01 08:59:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 09:01:36]

Description was changed from

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
==========

to

==========
[Reland] Remove style spans to follow the styles of the block element

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html

Committed: https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0
Cr-Commit-Position: refs/heads/master@{#403428}
==========

[commit-bot: I haz the power, 2016-07-01 09:01:37]

Patchset 1 (id:??) landed as
https://crrev.com/7cd91bcaaf5ef14b3e76465b464902cd864eaea0
Cr-Commit-Position: refs/heads/master@{#403428}